-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dealing with transient problems #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
install_requires=['requests>=1.0.0, <2.0.0'] implies that request is uninstalled if a more recent version is installed. This behaviour will be removed, however module seems to work even with more recent version of request
Scaling n of request per seconds if more processes are active in a limited account
Minor fix
if a request fails with a known transitory error (something bad has happened, Something went wrong while fetching from LDFeatureContainerAdaptor), it could be done automatically (for a certain amount of retries) before raising exceptions
By settings timeouts and internal retries I can improve performances (even with sleeping times between each retry)
The main problem when submitting more queries than permitted is that ensembl limit 15 request per second, so there's no need to fix the internal number. By submitting more than 15 request per second, the EnsemblRestRateLimitError exception will be reaised. The user will check his code to deal with exceptions or avoding to submit multiple clients using pyEnsemblRest API
The only problems I can't deal are transitory problems on results (result is different when submitting two times the same request - as here, scrutinizer failed a previous passed test). When such problems arise, we have to contant the ensembl team |
An ensembl id used in test was removed recently. I've splitted code in order to do small functions in my classes
I rewrote some functions in order to improve scrutinizer score. I've updated tests since one entry was removed from ensembl. Regards, Paolo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've updated code. Briefly I have:
setup.py
to use the more recentrequests
librarysomething bad has happened
andSomething went wrong while fetching from LDFeatureContainerAdaptor
(400) transient problemsThank you,
Paolo